guozhangwang commented on code in PR #18722: URL: https://github.com/apache/kafka/pull/18722#discussion_r1945350726
########## streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java: ########## @@ -3062,7 +3062,7 @@ <GK, GV, RV> KStream<K, RV> leftJoin(final GlobalKTable<GK, GV> globalTable, * @see #map(KeyValueMapper) */ <KOut, VOut> KStream<KOut, VOut> process( - final ProcessorSupplier<? super K, ? super V, KOut, VOut> processorSupplier, + final ProcessorSupplier<? super K, ? super V, ? extends KOut, ? extends VOut> processorSupplier, Review Comment: @mjsax sorry I just saw this from the community slack --- I read the JIRA ticket and the PR itself, and this looks great to me (we should have done it a while ago, thanks for completing it). As for https://github.com/apache/kafka/pull/18721#discussion_r1934537661 I gave some thought on it, and KLeft/KRight/VLeft/VRight sounds reasonable as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org