VedarthConfluent commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1964955176
##########
core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala:
##########
@@ -110,7 +110,9 @@ object KafkaDockerWrapper extends Logging {
case Some(str) => str
case None => throw new RuntimeException("CLUSTER_ID environment variable
is not set.")
}
- Array("format", "--cluster-id=" + clusterId, "-c",
s"${configsPath.toString}/server.properties", "--standalone")
+ // We maintain static voter configurations in Docker Hub images for better
version compatibility and deployment stability,
Review Comment:
imo if we decide to not support dynamic voters for docker image, we should
improve the error scenario as user may not know why the default kafka 4.0.0
configs do not work in docker image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
