chia7712 commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1965100766
##########
core/src/main/scala/kafka/docker/KafkaDockerWrapper.scala:
##########
@@ -52,7 +53,14 @@ object KafkaDockerWrapper extends Logging {
}
val formatCmd = formatStorageCmd(finalConfigsPath, envVars)
- StorageTool.main(formatCmd)
+ try {
+ StorageTool.main(formatCmd)
+ } catch {
+ case terseFailure: TerseFailure => if
(terseFailure.getMessage.contains(QuorumConfig.QUORUM_VOTERS_CONFIG)) {
+ throw new TerseFailure("The Docker image does not support Dynamic
Quorum yet.")
Review Comment:
this comment is too short. Maybe we should say "To maximize compatibility,
the Docker image continues to use static voters, which are supported in 3.7 and
later."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
