chia7712 commented on code in PR #18844:
URL: https://github.com/apache/kafka/pull/18844#discussion_r1964980767
##########
core/src/test/scala/unit/kafka/docker/KafkaDockerWrapperTest.scala:
##########
@@ -133,7 +133,7 @@ class KafkaDockerWrapperTest {
val configsPath = Paths.get("/path/to/configs")
val envVars = Map("CLUSTER_ID" -> "MYwKGPhXQZidgd0qMv8Mkw")
- val expected = Array("format", "--cluster-id=MYwKGPhXQZidgd0qMv8Mkw",
"-c", "/path/to/configs/server.properties")
+ val expected = Array("format", "--cluster-id=MYwKGPhXQZidgd0qMv8Mkw",
"-c", "/path/to/configs/server.properties", "--standalone")
Review Comment:
The risk is that the Docker Hub documentation is based on static voters. If
the 4.0 image uses dynamic voter configurations, users updating to
`apache/kafka:latest` could encounter errors running the image.
I agree that it will be better to encourage users to use dynamic voter, but
it can be addressed in follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
