dajac commented on code in PR #20847:
URL: https://github.com/apache/kafka/pull/20847#discussion_r2569550442
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -1130,3 +1133,10 @@ object DynamicRemoteLogConfig {
RemoteLogManagerConfig.REMOTE_LOG_READER_THREADS_PROP
)
}
+
+object DynamicCoordinatorLogConfig {
+ val ReconfigurableConfigs = Set(
+ GroupCoordinatorConfig.APPEND_MAX_BUFFER_SIZE_CONFIG,
+ ShareCoordinatorConfig.APPEND_MAX_BUFFER_SIZE_CONFIG
+ )
+}
Review Comment:
I wonder whether we should put those in GroupCoordinatorConfig in order to
keep all the configs related stuff in that class. What do you guys think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
