chia7712 commented on code in PR #20847:
URL: https://github.com/apache/kafka/pull/20847#discussion_r2569641695
##########
clients/src/main/java/org/apache/kafka/common/utils/BufferSupplier.java:
##########
@@ -30,6 +31,7 @@
* iterating over the records in the batch.
*/
public abstract class BufferSupplier implements AutoCloseable {
+ protected final AtomicLong cachedSize = new AtomicLong();
Review Comment:
The synchronization needed for [this
comment](https://github.com/apache/kafka/pull/20847#discussion_r2505134702) is
not obsolete since we adopted [this new
style](https://github.com/apache/kafka/pull/20847#discussion_r2557315589).
Consequently, +1 to use `long`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
