dajac commented on code in PR #20847:
URL: https://github.com/apache/kafka/pull/20847#discussion_r2569554079
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -708,6 +719,13 @@ public int offsetMetadataMaxSize() {
return offsetMetadataMaxSize;
}
+ /**
+ * The maximum buffer size that the coordinator can cache.
+ */
+ public int appendMaxBufferSize() {
+ return
config.getInt(GroupCoordinatorConfig.APPEND_MAX_BUFFER_SIZE_CONFIG);
Review Comment:
For the reference, I recall having performance issues with this approach on
hot-paths because the config is synchronised. It may be OK here but it is worth
keeping it in mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
