kamalcph commented on code in PR #20811:
URL: https://github.com/apache/kafka/pull/20811#discussion_r2649462672
##########
docs/operations/tiered-storage.md:
##########
@@ -89,9 +89,13 @@ After build successfully, there should be a
`kafka-storage-x.x.x-test.jar` file
# Note, please make sure the brokers need to have access to this directory
rsm.config.dir=/tmp/kafka-remote-storage
- # This needs to be changed if number of brokers in the cluster is more
than 1
+ # For single broker cluster, set this to 1. Default is 3 for clusters with
3 or more brokers.
rlmm.config.remote.log.metadata.topic.replication.factor=1
+ # The minimum number of replicas that must acknowledge a write to remote
log metadata topic.
Review Comment:
```suggestion
# The minimum number of insync replicas that must acknowledge a write to
remote log metadata topic.
```
##########
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##########
@@ -370,4 +375,58 @@ public void testInitializationFailure() throws
IOException, InterruptedException
Exit.resetExitProcedure();
}
}
+
+ @ClusterTest
+ public void testRemoteLogMetadataTopicMinIsr() throws ExecutionException,
InterruptedException {
+ // Initialize the manager which will create the __remote_log_metadata
topic
+ TopicBasedRemoteLogMetadataManager rlmm = topicBasedRlmm();
+ verifyRemoteLogMetadataTopicMinIsr(rlmm, (short) 2, "default value");
Review Comment:
Could you address this minor comment? Why do we want to re-initialize the
RLMM?
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -63,6 +65,7 @@ public final class TopicBasedRemoteLogMetadataManagerConfig {
"Default: -1, that means unlimited. Users can configure this value
based on their use cases. " +
"To avoid any data loss, this value should be more than the
maximum retention period of any topic enabled with " +
"tiered storage in the cluster.";
+ public static final String REMOTE_LOG_METADATA_TOPIC_MIN_ISR_DOC = "The
minimum number of replicas that must acknowledge a write to remote log metadata
topic.";
Review Comment:
```suggestion
public static final String REMOTE_LOG_METADATA_TOPIC_MIN_ISR_DOC = "The
minimum number of insync replicas that must acknowledge a write to remote log
metadata topic.";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
