jiafu1115 commented on code in PR #20811: URL: https://github.com/apache/kafka/pull/20811#discussion_r2649980205
########## docs/getting-started/upgrade.md: ########## @@ -33,7 +33,7 @@ type: docs ### Notable changes in 4.3.0 * Two new configs have been introduced: `group.coordinator.cached.buffer.max.bytes` and `share.coordinator.cached.buffer.max.bytes`. They allow the respective coordinators to set the maximum buffer size retained for reuse. For further details, please refer to [KIP-1196](https://cwiki.apache.org/confluence/x/hA5JFg). - + * The new config have been introduced: `rlmm.config.remote.log.metadata.topic.min.isr` with 2 as default value. You can update the value for the existed __remote_log_metadata topic via kafka-configs.sh if needed. For further details, please refer to [KIP-1235](https://cwiki.apache.org/confluence/x/yommFw). Review Comment: Hi @chia7712 Thanks for your reminder. I check the code and find the prefix can be configured by "RemoteLogManagerConfig#REMOTE_LOG_METADATA_MANAGER_CONFIG_PREFIX_PROP". So it make sense to do the change. I already done with change. You can help to review again. thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
