jiafu1115 commented on code in PR #20811:
URL: https://github.com/apache/kafka/pull/20811#discussion_r2649487221
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerConfig.java:
##########
@@ -63,6 +65,7 @@ public final class TopicBasedRemoteLogMetadataManagerConfig {
"Default: -1, that means unlimited. Users can configure this value
based on their use cases. " +
"To avoid any data loss, this value should be more than the
maximum retention period of any topic enabled with " +
"tiered storage in the cluster.";
+ public static final String REMOTE_LOG_METADATA_TOPIC_MIN_ISR_DOC = "The
minimum number of replicas that must acknowledge a write to remote log metadata
topic.";
Review Comment:
@kamalcph
Thanks for your review. I feel it might be slightly redundant to use
‘insync’ as a prefix.” , `acknowledge `is the expected behavior and `insync `is
the result of behavior. So WDTY? just keep it unchanged so that keep the same
style with TRANSACTIONS_TOPIC_MIN_ISR_DOC ?
Note: TRANSACTIONS_TOPIC_MIN_ISR_DOC
public static final String TRANSACTIONS_TOPIC_MIN_ISR_DOC = "The minimum
number of replicas that must acknowledge a write to transaction topic in order
to be considered successful.";
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
