jiafu1115 commented on code in PR #20811:
URL: https://github.com/apache/kafka/pull/20811#discussion_r2649478727
##########
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##########
@@ -370,4 +375,58 @@ public void testInitializationFailure() throws
IOException, InterruptedException
Exit.resetExitProcedure();
}
}
+
+ @ClusterTest
+ public void testRemoteLogMetadataTopicMinIsr() throws ExecutionException,
InterruptedException {
+ // Initialize the manager which will create the __remote_log_metadata
topic
+ TopicBasedRemoteLogMetadataManager rlmm = topicBasedRlmm();
+ verifyRemoteLogMetadataTopicMinIsr(rlmm, (short) 2, "default value");
Review Comment:
Hi @kamalcph
The field TopicBasedRemoteLogMetadataManagerTest#remoteLogMetadataManager
maybe null if the first running case is this one. So we can using
topicBasedRlmm() similar with some other cases to make sure it must be
initialized. If it is already initialized. it will return the existed one.
BTW: I remove all others cases and debug with the case if we only use
remoteLogMetadataManager directly instead of topicBasedRlmm(). You can see it
is null.
<img width="1047" height="277" alt="Image"
src="https://github.com/user-attachments/assets/4f9126d9-4bd7-4c0a-b323-7b4a415c0f94";
/>
thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
