chia7712 commented on code in PR #21384:
URL: https://github.com/apache/kafka/pull/21384#discussion_r2792592528
##########
server/src/main/java/org/apache/kafka/server/config/DynamicBrokerConfig.java:
##########
@@ -279,4 +279,8 @@ public static class DynamicReplicationConfig {
public static final Set<String> RECONFIGURABLE_CONFIGS = Set.of(
ReplicationConfigs.FOLLOWER_FETCH_LAST_TIERED_OFFSET_ENABLE_CONFIG);
}
+
+ public static class DynamicQuotaConfig {
Review Comment:
Is it a kind of decoration?
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -56,7 +56,9 @@ import scala.jdk.OptionConverters.RichOptional
object KafkaConfig {
def main(args: Array[String]): Unit = {
- System.out.println(configDef.toHtml(4, (config: String) =>
"brokerconfigs_" + config,
+ val combined = new ConfigDef(configDef)
+ QuotaConfig.brokerQuotaConfigs().configKeys().forEach((_, v) =>
combined.define(v))
Review Comment:
would you mind adding comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
