nileshkumar3 commented on code in PR #21976:
URL: https://github.com/apache/kafka/pull/21976#discussion_r3242192236
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##########
@@ -1086,7 +1086,7 @@ public void testSourceConnectorPluginConfig() throws
ClassNotFoundException {
testConnectorPluginConfig(
"source",
SampleSourceConnector::new,
- SampleSourceConnector::config,
+ SampleSourceConnector::configWithInternalKey,
Review Comment:
right test still pass, this was added to test filtering logic. Other Test
fails if we add internal key to the config. For now internal key is not added
in the existing definition. i separated config vs configWithInternalKey to keep
existing tests unaffected and to test the filtering logic in this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
