nileshkumar3 commented on code in PR #21976:
URL: https://github.com/apache/kafka/pull/21976#discussion_r3260082105
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##########
@@ -1086,7 +1086,7 @@ public void testSourceConnectorPluginConfig() throws
ClassNotFoundException {
testConnectorPluginConfig(
"source",
SampleSourceConnector::new,
- SampleSourceConnector::config,
+ SampleSourceConnector::configWithInternalKey,
Review Comment:
@mimaison Happy to go the other way if you prefer: revert
testSourceConnectorPluginConfig
back to SampleSourceConnector::config and add a separate dedicated test that
uses configWithInternalKey purely to verify internal keys are filtered out.
That keeps the existing test untouched and isolates the new coverage. Let me
know which you'd prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
