nileshkumar3 commented on code in PR #21976:
URL: https://github.com/apache/kafka/pull/21976#discussion_r3247424592
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##########
@@ -1086,7 +1086,7 @@ public void testSourceConnectorPluginConfig() throws
ClassNotFoundException {
testConnectorPluginConfig(
"source",
SampleSourceConnector::new,
- SampleSourceConnector::config,
+ SampleSourceConnector::configWithInternalKey,
Review Comment:
Added an explicit assertFalse assertion that INTERNAL_ONLY_CONFIG_KEY does
not appear in the connectorPluginConfig result.
This directly proves the filtering logic works. The count-based assertEquals
alone was not sufficient: if the !configKey.internalConfig filter were removed
from connectorPluginConfig, the count would go from 2 to 3 and the count
assertion would fail — but only when configWithInternalKey is used as input.
The new assertFalse makes the intent explicit and self-documenting regardless
of input size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
