nileshkumar3 commented on code in PR #21976:
URL: https://github.com/apache/kafka/pull/21976#discussion_r3247424592
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java:
##########
@@ -1086,7 +1086,7 @@ public void testSourceConnectorPluginConfig() throws
ClassNotFoundException {
testConnectorPluginConfig(
"source",
SampleSourceConnector::new,
- SampleSourceConnector::config,
+ SampleSourceConnector::configWithInternalKey,
Review Comment:
You're right that tests pass either way today. Switched to
configWithInternalKey
so the test actually exercises the filter (with config() removing
!configKey.internalConfig wouldn't fail anything). I kept it separate from
config() because defineInternal uses an empty group, which breaks other
AbstractHerderTest assertions. Also added an explicit assertFalse on
INTERNAL_ONLY_CONFIG_KEY to make the intent self-documenting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
