fvaleri commented on code in PR #22384:
URL: https://github.com/apache/kafka/pull/22384#discussion_r3324627015
##########
metadata/src/main/java/org/apache/kafka/metadata/storage/Formatter.java:
##########
@@ -243,13 +229,33 @@ public BootstrapMetadata bootstrapMetadata() {
return bootstrapMetadata;
}
+ /**
+ * Validates the correctness of the given cluster id. A valid cluster id
is a base64, urlencoded, no padding
+ * representation of a {@link Uuid}. These checks do not validate the
absence of <code>-</code> character as
+ * {@link Uuid#randomUuid()} avoids them only for convenience reasons.
Review Comment:
I would explicitly mention support for already generated CIDs. Basically
it's for historical reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
