chia7712 commented on code in PR #22384:
URL: https://github.com/apache/kafka/pull/22384#discussion_r3387400823
##########
server/src/test/java/org/apache/kafka/server/ReconfigurableQuorumIntegrationTest.java:
##########
@@ -255,7 +255,7 @@ public void testNewVoterAutoRemovesAndAdds() throws
Exception {
@Test
public void testRemoveAndAddVoterWithValidClusterId() throws Exception {
final var nodes = new TestKitNodes.Builder()
- .setClusterId("test-cluster")
+ .setClusterId("5EqhrOPYSkaSsXk4RYkNow")
Review Comment:
If the "=" character is the main issue, we could file a KIP for it. KIP-78
explicitly states that the valid characters are `[a-zA-Z0-9_\-]+`, but it seems
we never implemented that constraint :cry:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
