fvaleri commented on code in PR #22384:
URL: https://github.com/apache/kafka/pull/22384#discussion_r3385850084
##########
server/src/test/java/org/apache/kafka/server/ReconfigurableQuorumIntegrationTest.java:
##########
@@ -255,7 +255,7 @@ public void testNewVoterAutoRemovesAndAdds() throws
Exception {
@Test
public void testRemoveAndAddVoterWithValidClusterId() throws Exception {
final var nodes = new TestKitNodes.Builder()
- .setClusterId("test-cluster")
+ .setClusterId("5EqhrOPYSkaSsXk4RYkNow")
Review Comment:
> I think the desired behavior should follow the KIP, which is no validation
while formatting, unless we open another KIP to change that.
Maybe I expressed that poorly, but it is what I was saying. Follow the KIP
as default and add a flag to enable UUID validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
