fvaleri commented on code in PR #22384:
URL: https://github.com/apache/kafka/pull/22384#discussion_r3380564544


##########
server/src/test/java/org/apache/kafka/server/ReconfigurableQuorumIntegrationTest.java:
##########
@@ -255,7 +255,7 @@ public void testNewVoterAutoRemovesAndAdds() throws 
Exception {
     @Test
     public void testRemoveAndAddVoterWithValidClusterId() throws Exception {
         final var nodes = new TestKitNodes.Builder()
-            .setClusterId("test-cluster")
+            .setClusterId("5EqhrOPYSkaSsXk4RYkNow")

Review Comment:
   What about adding a flag to enforce UUID validation? That way you get the 
desired behavior as opt-in and no existing procedure would be broken.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to