gaurav-narula commented on code in PR #22384:
URL: https://github.com/apache/kafka/pull/22384#discussion_r3390827336
##########
server/src/test/java/org/apache/kafka/server/ReconfigurableQuorumIntegrationTest.java:
##########
@@ -255,7 +255,7 @@ public void testNewVoterAutoRemovesAndAdds() throws
Exception {
@Test
public void testRemoveAndAddVoterWithValidClusterId() throws Exception {
final var nodes = new TestKitNodes.Builder()
- .setClusterId("test-cluster")
+ .setClusterId("5EqhrOPYSkaSsXk4RYkNow")
Review Comment:
Sounds good @chia7712 . I'll take up drafting a KIP for proposing a new
validation flag to `kafka-storage.sh` and limiting the check to the regex above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
