zheguang commented on code in PR #22999:
URL: https://github.com/apache/kafka/pull/22999#discussion_r3711786080
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##########
@@ -947,6 +954,38 @@ private static Map<String, SortedSet<Integer>>
toTasksAssignment(final List<Stre
.collect(Collectors.toMap(StreamsGroupHeartbeatResponseData.TaskIds::subtopologyId,
taskId -> new TreeSet<>(taskId.partitions())));
}
+ private Set<String> unknownSubtopologies(final
List<StreamsGroupHeartbeatResponseData.TaskIds> activeTasks,
Review Comment:
Somehow my mind was drifted into "corrupted assignment = invalid partition",
which would have reached for metadata etc... But really is just catching the
subtopologies not known to client here, rather than later at reconciliation.
This patch looks good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
