mjsax commented on code in PR #22999:
URL: https://github.com/apache/kafka/pull/22999#discussion_r3716434583
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##########
@@ -947,6 +954,38 @@ private static Map<String, SortedSet<Integer>>
toTasksAssignment(final List<Stre
.collect(Collectors.toMap(StreamsGroupHeartbeatResponseData.TaskIds::subtopologyId,
taskId -> new TreeSet<>(taskId.partitions())));
}
+ private Set<String> unknownSubtopologies(final
List<StreamsGroupHeartbeatResponseData.TaskIds> activeTasks,
Review Comment:
Yes, exactly. -- With KIP-1357 we introduce custom task assignors, and we
don't yet have any guard on the broker which would validate the computed
assignment (Also not 100% clear, what the broker could do about it... -- still
brainstorming on this question). A buggy assignor could just "invent" a
non-existing task which maps to no sub-topology and hence, adding such a guard
client side would give us at least a clean error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
