lianetm commented on code in PR #22999:
URL: https://github.com/apache/kafka/pull/22999#discussion_r3731492694


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##########
@@ -775,6 +776,12 @@ public void 
onHeartbeatSuccess(StreamsGroupHeartbeatResponse response) {
                 return;
             }
 
+            final Set<String> unknownSubtopologies = 
unknownSubtopologies(activeTasks, standbyTasks, warmupTasks);

Review Comment:
   >No, it's about a unknown sub-topology.
   
   Ok, me not knowing enough KS here :) I was simplifying my mental model on 
this thinking it would map to the case of consumer receiving an "unknown 
partiton"
   
   > > But we could also have a "bad" assignment if it includes the same 
partition twice.
   > 
   > No, that's protected broker side.
   
   Great, covered then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to