lianetm commented on code in PR #22999:
URL: https://github.com/apache/kafka/pull/22999#discussion_r3729128431
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##########
@@ -775,6 +776,12 @@ public void
onHeartbeatSuccess(StreamsGroupHeartbeatResponse response) {
return;
}
+ final Set<String> unknownSubtopologies =
unknownSubtopologies(activeTasks, standbyTasks, warmupTasks);
Review Comment:
this is a guard against a "bad" assignment with a partition not in the
subscription, makes sense.
But we could also have a "bad" assignment if it includes the same partition
twice. Should we guard against that too? (that would probably fail on
`toTasksAssignment` `toMap`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
