andrewgrantcflt commented on code in PR #23245:
URL: https://github.com/apache/kafka/pull/23245#discussion_r3855042042
##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -247,6 +247,7 @@ class ControllerServer(
setQuorumFeatures(quorumFeatures).
setDefaultReplicationFactor(config.defaultReplicationFactor.toShort).
setDefaultNumPartitions(config.numPartitions.intValue()).
+ setMaxRecordsPerBatch(config.controllerMaxRecordsPerBatch).
Review Comment:
Fixed.
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1231,7 +1252,7 @@ static void
validateTotalNumberOfPartitions(CreateTopicsRequestData request, int
} else {
totalPartitions += topic.assignments().size();
}
- if (totalPartitions > MAX_PARTITIONS_PER_BATCH) {
+ if (totalPartitions > maxRecordsPerBatch) {
throw new PolicyViolationException("Excessively large number
of partitions per request.");
Review Comment:
Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
