AndrewJSchofield commented on code in PR #23245:
URL: https://github.com/apache/kafka/pull/23245#discussion_r3873828811
##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -267,7 +267,8 @@ class ControllerServer(
setDelegationTokenExpiryCheckIntervalMs(delegationTokenManagerConfigs.delegationTokenExpiryCheckIntervalMs).
setUncleanLeaderElectionCheckIntervalMs(config.uncleanLeaderElectionCheckIntervalMs).
setControllerPerformanceSamplePeriodMs(config.controllerPerformanceSamplePeriodMs).
-
setControllerPerformanceAlwaysLogThresholdMs(config.controllerPerformanceAlwaysLogThresholdMs)
+
setControllerPerformanceAlwaysLogThresholdMs(config.controllerPerformanceAlwaysLogThresholdMs).
+ setMaxRecordsPerBatch(config.controllerMaxRecordsPerBatch)
Review Comment:
nit: For consistency, this should be `setControllerMaxRecordsPerBatch`.
##########
metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java:
##########
@@ -96,6 +96,7 @@ public void testReplay() {
setQuorumFeatures(new QuorumFeatures(0,
QuorumFeatures.defaultSupportedFeatureMap(true),
() -> Set.of(0))).
+ setMaxRecordsPerBatch(10_000).
Review Comment:
Should you use `KRaftConfigs.CONTROLLER_MAX_RECORDS_PER_BATCH_DEFAULT`
instead of `10_000` here like in the other tests?
##########
metadata/src/test/java/org/apache/kafka/controller/FeatureControlManagerTest.java:
##########
@@ -98,6 +109,7 @@ public void testUpdateFeatures() {
FeatureControlManager manager = new FeatureControlManager.Builder().
setQuorumFeatures(features(TestFeatureVersion.FEATURE_NAME, 0, 2)).
setSnapshotRegistry(snapshotRegistry).
+ setMaxRecordsPerBatch(10_000).
Review Comment:
`KRaftConfigs.CONTROLLER_MAX_RECORDS_PER_BATCH_DEFAULT`?
##########
metadata/src/test/java/org/apache/kafka/controller/ConfigurationControlManagerTest.java:
##########
@@ -141,6 +153,7 @@ static <A, B> Entry<A, B> entry(A a, B b) {
public void testReplay() {
ConfigurationControlManager manager = new
ConfigurationControlManager.Builder().
setKafkaConfigSchema(SCHEMA).
+ setMaxRecordsPerBatch(10_000).
Review Comment:
`KRaftConfigs.CONTROLLER_MAX_RECORDS_PER_BATCH_DEFAULT`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
