andrewgrantcflt commented on code in PR #23245:
URL: https://github.com/apache/kafka/pull/23245#discussion_r3854645775
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -1231,7 +1252,7 @@ static void
validateTotalNumberOfPartitions(CreateTopicsRequestData request, int
} else {
totalPartitions += topic.assignments().size();
}
- if (totalPartitions > MAX_PARTITIONS_PER_BATCH) {
+ if (totalPartitions > maxRecordsPerBatch) {
throw new PolicyViolationException("Excessively large number
of partitions per request.");
Review Comment:
I do agree. Is it OK to change the error message? I know users probably
shouldn't be depending on the message, but in practice it inevitably will
happen.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
