kevin-wu24 commented on PR #23245: URL: https://github.com/apache/kafka/pull/23245#issuecomment-5430905661
> I'm not 100% sure though so maybe I create a ticket and do that as a follow-up? I think the behavior change is pretty straightforward since it mirrors the other managers. Can we add it as part of this PR? > For the registration related comment, my guess is in some places we'd never expect more than 10,000 records to be generated. For example in the broker registration code I'm guessing we don't register or unregister more than 10,000 brokers at a time :) Yes, we won't have more than 10,000 registration or unregistration records at the same time. Take a look at `QuorumController#handleBrokerShutdown`. It could be possible more than 10k PartitionChangeRecords are generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
