gabriellefu commented on code in PR #23121:
URL: https://github.com/apache/kafka/pull/23121#discussion_r3917564879
##########
core/src/main/scala/kafka/server/ControllerConfigurationValidator.scala:
##########
@@ -134,8 +144,12 @@ class ControllerConfigurationValidator(kafkaConfig:
KafkaConfig) extends Configu
ClientMetricsConfigs.validate(resource.name(), filteredConfigs)
case GROUP =>
validateGroupName(resource.name())
- val filteredConfigs = filterAndValidateNullConfigs(newConfigs, "group")
- GroupConfig.validate(filteredConfigs,
kafkaConfig.groupCoordinatorConfig, kafkaConfig.shareGroupConfig)
+ // Skip once every broker in the cluster is guaranteed to already
validate this on the
+ // forwarding broker. See the class-level doc for why this can't just
be removed outright.
Review Comment:
since we are not adding forwarded to the validation, we can't inline this
comment anymore, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
