gabriellefu commented on code in PR #23121:
URL: https://github.com/apache/kafka/pull/23121#discussion_r3868468406
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupConfigTest.java:
##########
@@ -384,59 +384,34 @@ public void
testStreamsRackAwareAssignmentTagsValidation() {
@Test
public void testStreamsAssignorNameValidation() {
- // A registered assignor name is accepted.
- Map<String, String> props = createValidGroupConfig();
- props.put(GroupConfig.STREAMS_ASSIGNOR_NAME_CONFIG, "sticky");
- doTestValidProps(props);
-
- // An unknown assignor name is rejected with INVALID_CONFIG.
- props = createValidGroupConfig();
- props.put(GroupConfig.STREAMS_ASSIGNOR_NAME_CONFIG, "does-not-exist");
- doTestInvalidProps(props, InvalidConfigurationException.class);
- }
-
- @Test
- public void testStreamsAssignorNameSelectsCustomAssignor() {
Review Comment:
i have added them back, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
