gabriellefu commented on code in PR #23121:
URL: https://github.com/apache/kafka/pull/23121#discussion_r3868434917
##########
core/src/test/scala/unit/kafka/server/ControllerConfigurationValidatorTest.scala:
##########
@@ -219,6 +224,25 @@ class ControllerConfigurationValidatorTest {
config.put("foobar", "abc")
assertEquals("Unknown group config name: foobar",
assertThrows(classOf[InvalidConfigurationException], () =>
validator.validate(
- new ConfigResource(GROUP, "group"), config, emptyMap())).getMessage)
+ new ConfigResource(GROUP, "group"), config, emptyMap(),
preGroupBrokerValidationMv)).getMessage)
+ }
+
+ @Test
+ def testInvalidGroupConfigStillRejectedBelowGatedMetadataVersion(): Unit = {
+ val config = new util.TreeMap[String, String]()
+ config.put("foobar", "abc")
+ assertEquals("Unknown group config name: foobar",
+ assertThrows(classOf[InvalidConfigurationException], () =>
validator.validate(
+ new ConfigResource(GROUP, "group"), config, emptyMap(),
MetadataVersion.IBP_4_4_IV2)).getMessage)
+ }
+
+ @Test
+ def
testInvalidGroupConfigSkippedOnceMetadataVersionGuaranteesBrokerValidation():
Unit = {
Review Comment:
applied, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
