gabriellefu commented on code in PR #23121:
URL: https://github.com/apache/kafka/pull/23121#discussion_r3868456441
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfig.java:
##########
@@ -477,6 +477,38 @@ public static void validateNames(Map<String, String>
newGroupConfig) {
}
}
+ /**
+ * Validate a GROUP config change on the forwarding broker, before it is
sent to the
+ * controller. Runs the full set of checks in {@link #validate}.
+ *
+ * @param newGroupConfig The new unparsed group config overrides.
+ * @param groupCoordinatorConfig The group coordinator config.
+ * @param shareGroupConfig The share group config.
+ */
+ public static void validateOnBroker(
+ Map<String, String> newGroupConfig,
+ GroupCoordinatorConfig groupCoordinatorConfig,
+ ShareGroupConfig shareGroupConfig
+ ) {
+ validate(newGroupConfig, groupCoordinatorConfig, shareGroupConfig);
+ }
+
+ /**
+ * Validate a GROUP config change on the controller. Runs the full set of
checks in
+ * {@link #validate}.
Review Comment:
thanks, i have updated it to
`* {@link #validate}. Below metadata version 4.5-IV0, dynamic group configs
are validated \n * on the controller. From 4.5-IV0 on, they are validated on
the broker in/n
* {@link #validateOnBroker} and the controller no longer validates. `
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
