dejan2609 opened a new pull request, #23796:
URL: https://github.com/apache/kafka/pull/23796

   **Jira ticket:** KAFKA-12744
   
   **Note:** I have revisited my two previous attempts (but this time with 
Claude's help):
   - #10626
   - #19265
   
   **Migration guide:** https://argparse4j.github.io/migration.html#to-0-8-0
    
   **Release notes:** 
   - https://github.com/argparse4j/argparse4j/releases/tag/argparse4j-0.8.0
   - https://github.com/argparse4j/argparse4j/releases/tag/argparse4j-0.8.1
   - https://github.com/argparse4j/argparse4j/releases/tag/argparse4j-0.9.0
    
   **Git diff:** 
https://github.com/argparse4j/argparse4j/compare/argparse4j-0.7.0...argparse4j-0.9.0
   **Maven** Central link: 
https://central.sonatype.com/artifact/net.sourceforge.argparse4j/argparse4j/0.9.0/versions
   
   ___
   
   **Change explained in more detail:**
   
   Bump argparse4j to 0.9.0 and migrate all usages away from APIs that were 
deprecated in 0.8.0 (see https://argparse4j.github.io/migration.html#to-0-8-0). 
Kafka compiles with -Xlint:all -Werror, so every deprecated call has to go.
   
   - Replace ArgumentParsers.newArgumentParser(...) with the builder API 
ArgumentParsers.newFor(...)...build() in core, tools, shell, generator, trogdor 
and connect-mirror. In StorageTool and KafkaDockerWrapper the old 4-arg call is 
reduced to newFor(..).fromFilePrefix("@").build(), since addHelp(true) and 
prefixChars("-") are the builder defaults.
   - HelpScreenException moved from argparse4j.internal to argparse4j.helper; 
update imports accordingly.
   - Update the argparse4j version in LICENSE-binary.
   
   PrintVersionAndExitAction:
   In 0.9.0, ArgumentAction gains run(..., Consumer<Object> valueSetter) as a 
default method, which argparse4j now invokes, while the old 5-arg run(...) is 
deprecated but still abstract. The version-printing logic now lives in the new 
6-arg method; the 5-arg overload is kept only to satisfy the interface, is 
marked @Deprecated, and delegates to the new one. When argparse4j removes the 
legacy method, the overload can simply be deleted. Behaviour of --version is 
unchanged.
   
   
   Co-Authored-By: Claude Opus 5.5 <[email protected]>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to