dejan2609 commented on code in PR #23796:
URL: https://github.com/apache/kafka/pull/23796#discussion_r4322596960
##########
tools/src/main/java/org/apache/kafka/tools/PrintVersionAndExitAction.java:
##########
@@ -33,14 +34,28 @@ public void run(
Argument arg,
Map<String, Object> attrs,
String flag,
- Object value
+ Object value,
+ Consumer<Object> valueSetter
) {
String version = AppInfoParser.getVersion();
String commitId = AppInfoParser.getCommitId();
System.out.println(version + " (Commit:" + commitId + ")");
Exit.exit(0);
}
+ // Deprecated in argparse4j 0.9.0 but still abstract, so it must be
implemented.
+ @Deprecated
+ @Override
+ public void run(
Review Comment:
Note: I recently started to work with Claude Opus 5.5. and although I'am a
DevOps specialist with a solid Java background I can actually recall an
**_exact_** moment from a Claude session where model tricked me into using a
working but overkill solution here.
Thanks for a review, I'll be more careful in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
