dejan2609 commented on PR #23796:
URL: https://github.com/apache/kafka/pull/23796#issuecomment-6146047273

   _Testing prologue:_ 
https://github.com/apache/kafka/pull/10626#issuecomment-830813257 
   
   I did a fair share of testing: 
   - Gradle tasks (that were executed locally):
     - `./gradlew checkstyleMain checkstyleTest spotlessCheck` 
:white_check_mark: 
     - `./gradlew spotlessApply` :white_check_mark: 
     - `./gradlew spotbugsMain spotbugsTest -x test` :white_check_mark: 
   - Affected tests are executed during Claude session :white_check_mark: 
   - Distribution is created `./gradlew clean releaseTarGz` and quickstart test 
are performed (https://kafka.apache.org/quickstart) :white_check_mark: 
   
   
   **On top of this CLI is tested:** 
   ```
   dejan@home:~/kafka/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT$ git 
log -2 --oneline
   95baaabd475 (HEAD -> KAFKA-12744-argparse4j-upgrade, 
origin/KAFKA-12744-argparse4j-upgrade) KAFKA-12744: Upgrade argparse4j from 
0.7.0 to 0.9.0
   3a2eecc5c48 (upstream/trunk, upstream/HEAD) MINOR: Remove duplicate test 
dependency declarations (#23786)
   dejan@home:~/kafka/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT$ 
bin/kafka-transactions.sh --version
   4.5.0-SNAPSHOT (Commit:95baaabd475a52a1)
   dejan@home:~/kafka/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT$ 
bin/kafka-topics.sh --list --bootstrap-server localhost:9092
   __consumer_offsets
   quickstart-events
   dejan@home:~/kafka/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT$ 
bin/kafka-cluster.sh cluster-id --bootstrap-server localhost:9092
   Cluster ID: 5IQ1fd92TuycnZ1pQmhkHA
   dejan@home:~/kafka/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT$ 
bin/kafka-metadata-quorum.sh --bootstrap-server localhost:9092 describe --status
   ClusterId:              5IQ1fd92TuycnZ1pQmhkHA
   LeaderId:               1
   LeaderEpoch:            1
   HighWatermark:          3928
   MaxFollowerLag:         0
   MaxFollowerLagTimeMs:   0
   CurrentVoters:          [{"id": 1, "directoryId": "oodQpvbnRvKiVgS0i_iJPg", 
"endpoints": ["CONTROLLER://localhost:9093"]}]
   CurrentObservers:       []
   dejan@home:~/kafka/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT$ 
bin/kafka-storage.sh info --config config/server.properties
   Found log directory:
     /tmp/kraft-combined-logs
   
   Found metadata: {cluster.id=5IQ1fd92TuycnZ1pQmhkHA, 
directory.id=oodQpvbnRvKiVgS0i_iJPg, node.id=1, version=1}
   
   dejan@home:~/kafka/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT$ 
bin/kafka-features.sh --bootstrap-server localhost:9092 describe
   Feature: eligible.leader.replicas.version          SupportedMinVersion: 0    
            SupportedMaxVersion: 1                FinalizedVersionLevel: 1      
          Epoch: 4011
   Feature: group.version                             SupportedMinVersion: 0    
            SupportedMaxVersion: 1                FinalizedVersionLevel: 1      
          Epoch: 4011
   Feature: kraft.version                             SupportedMinVersion: 0    
            SupportedMaxVersion: 1                FinalizedVersionLevel: 1      
          Epoch: 4011
   Feature: metadata.version                          SupportedMinVersion: 
3.3-IV3          SupportedMaxVersion: 4.4-IV2          FinalizedVersionLevel: 
4.4-IV2          Epoch: 4011
   Feature: share.version                             SupportedMinVersion: 0    
            SupportedMaxVersion: 2                FinalizedVersionLevel: 2      
          Epoch: 4011
   Feature: streams.version                           SupportedMinVersion: 0    
            SupportedMaxVersion: 1                FinalizedVersionLevel: 1      
          Epoch: 4011
   Feature: transaction.version                       SupportedMinVersion: 0    
            SupportedMaxVersion: 2                FinalizedVersionLevel: 2      
          Epoch: 4011
   dejan@home:~/kafka/core/build/distributions/kafka_2.13-4.5.0-SNAPSHOT$ date
   Tue 13 Oct 14:27:53 CEST 2026
   ```
   
   :information_source: PR is ready for review :slightly_smiling_face: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to