mimaison commented on code in PR #23796:
URL: https://github.com/apache/kafka/pull/23796#discussion_r4315323392
##########
tools/src/main/java/org/apache/kafka/tools/PrintVersionAndExitAction.java:
##########
@@ -33,14 +34,28 @@ public void run(
Argument arg,
Map<String, Object> attrs,
String flag,
- Object value
+ Object value,
+ Consumer<Object> valueSetter
) {
String version = AppInfoParser.getVersion();
String commitId = AppInfoParser.getCommitId();
System.out.println(version + " (Commit:" + commitId + ")");
Exit.exit(0);
}
+ // Deprecated in argparse4j 0.9.0 but still abstract, so it must be
implemented.
+ @Deprecated
+ @Override
+ public void run(
Review Comment:
Can we remove the other `run()` method (there's a default in the interface)
and put the logic in this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
