chia7712 commented on code in PR #21416:
URL: https://github.com/apache/kafka/pull/21416#discussion_r4307977041
##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -361,6 +361,13 @@ class KafkaConfig private(doLog: Boolean, val props:
util.Map[_, _], enforceProv
warn(s"$configName is defined in ${processRoles.asScala.mkString(",
")}. It should be defined in the $expectedRole role. $extraMessage")
}
}
+ def warnIfDynamicQuotasInStaticConfig(): Unit = {
+ QuotaConfig.DYNAMIC_ONLY_BROKER_QUOTA_CONFIGS.asScala.foreach {
configName =>
+ if (originals.containsKey(configName)) {
Review Comment:
the originals contains the dynamic configs, so the warning message would
print on every dynamic config change, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
