chia7712 commented on code in PR #21416:
URL: https://github.com/apache/kafka/pull/21416#discussion_r4392000233
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -208,6 +208,7 @@ class BrokerServer(
val clientTelemetryExporterPlugin = new ClientTelemetryExporterPlugin()
+ config.dynamicConfig.warnIfBrokerQuotaConfigsInStaticConfig()
Review Comment:
I feel this approach became a bit complex. Maybe we could inline it in
BrokerServer.startup right after initialize() and then remove the tests?
```java
config.dynamicConfig.staticBrokerConfigs.keys
.filter(QuotaConfig.BROKER_QUOTA_CONFIGS.contains)
.foreach(name => warn(s"$name is set in the static configuration
file but is ignored at runtime; " +
"configure this property dynamically to take effect."))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
