chia7712 commented on code in PR #21416:
URL: https://github.com/apache/kafka/pull/21416#discussion_r4331478500
##########
server-common/src/main/java/org/apache/kafka/server/config/QuotaConfig.java:
##########
@@ -95,9 +95,14 @@ public class QuotaConfig {
public static final String
REPLICA_ALTER_LOG_DIRS_IO_MAX_BYTES_PER_SECOND_CONFIG =
"replica.alter.log.dirs.io.max.bytes.per.second";
public static final String
REPLICA_ALTER_LOG_DIRS_IO_MAX_BYTES_PER_SECOND_DOC = "A long representing the
upper bound (bytes/sec) on disk IO used for moving replica between log
directories on the same broker. " +
- "This property can be only set dynamically. It is suggested that
the limit be kept above 1MB/s for accurate behaviour.";
+ "This property can be only set dynamically, and defining it in the
static configuration file has no effect. It is suggested that the limit be kept
above 1MB/s for accurate behaviour.";
public static final long QUOTA_BYTES_PER_SECOND_DEFAULT = Long.MAX_VALUE;
+ public static final Set<String> DYNAMIC_ONLY_BROKER_QUOTA_CONFIGS = Set.of(
Review Comment:
Could we use `BROKER_QUOTA_CONFIGS` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
