chia7712 commented on code in PR #21416:
URL: https://github.com/apache/kafka/pull/21416#discussion_r4365374855
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -155,6 +155,18 @@ class DynamicBrokerConfig(private val kafkaConfig:
KafkaConfig) extends Logging
private var telemetryExporterPluginOpt:
Option[ClientTelemetryExporterPlugin] = _
private var currentConfig: KafkaConfig = _
+ /** Called from [[BrokerServer.startup]] so the reminder is logged once per
broker process. */
+ private[server] def warnIfBrokerQuotaConfigsInStaticConfig(): Unit = {
+ if (!kafkaConfig.processRoles.contains(ProcessRole.BrokerRole)) {
Review Comment:
It is already in the broker scope, right? If so, this check could be removed.
##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -2158,6 +2158,28 @@ class KafkaConfigTest {
assertEquals("requirement failed: controller.listener.names must contain
at least one value appearing in the 'listeners' configuration when running the
KRaft controller role", message)
}
+ @Test
+ def testWarnIfDynamicQuotasInStaticConfig(): Unit = {
Review Comment:
The method is not in KafkaConfig anymore, so we need to find another place
to move it to :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
