mjsax commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436223027
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -598,9 +606,9 @@ public void closeAndRecycleState() {
* 3. finally release the state manager lock
* </pre>
*/
- private void close(final boolean clean, final Map<TopicPartition, Long>
checkpoint) {
- if (clean && checkpoint != null) {
- executeAndMaybeSwallow(clean, () ->
stateMgr.checkpoint(checkpoint), "state manager checkpoint", log);
+ private void close(final boolean clean) {
+ if (clean && checkpointNeeded) {
Review comment:
A `if (clean)` should be sufficient now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
