guozhangwang commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436238804
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -107,6 +107,9 @@
private boolean commitNeeded = false;
private boolean commitRequested = false;
+ private boolean checkpointNeeded = false;
Review comment:
Actually I'm not too concerned of relying on `null` to indicate no need
to checkpoint, what I originally pointed out is that we are unnecessarily
accumulating and then distributing checkpoints between task manager and task,
which is already resolved in your PR. So I'd suggest we still just use a single
nullable `Map`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
