mjsax commented on a change in pull request #8820: URL: https://github.com/apache/kafka/pull/8820#discussion_r436233382
########## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ########## @@ -107,6 +107,9 @@ private boolean commitNeeded = false; private boolean commitRequested = false; + private boolean checkpointNeeded = false; Review comment: I actually had a similar thought, but I am torn though. Using two variables required to keep them "in sync" was is not great. However, using `null` is less explicit... Thus overall I am fine either way as both seems to provide the overall same good/bad ratio. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org