abbccdda commented on a change in pull request #8820:
URL: https://github.com/apache/kafka/pull/8820#discussion_r436237426
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java
##########
@@ -107,6 +107,9 @@
private boolean commitNeeded = false;
private boolean commitRequested = false;
+ private boolean checkpointNeeded = false;
Review comment:
A third option is Optional<Map<TopicPartition, Long>> which explicitly
states the checkpoint is null. However, I think the benefit here is minimal,
as `checkpointNeeded` sounds like a better state variable, than relying on the
struct itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
