[GitHub] [kafka] hachikuji commented on a change in pull request #8891: KAFKA-10143; Restore ability to change throttle of active reassignment

[GitBox]

hachikuji commented on a change in pull request #8891:
URL: https://github.com/apache/kafka/pull/8891#discussion_r442980855



##########
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##########
@@ -1685,10 +1702,9 @@ object ReassignPartitionsCommand extends Logging {
       opts.cancelOpt -> collection.immutable.Seq(
         opts.reassignmentJsonFileOpt
       ),
-      opts.listOpt -> collection.immutable.Seq(
-      )
+      opts.listOpt -> collection.immutable.Seq.empty

Review comment:
       I can revert. It looked a little more reasonable when next to the 
suggested alter command.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org