cmccabe commented on a change in pull request #8863:
URL: https://github.com/apache/kafka/pull/8863#discussion_r450505717



##########
File path: tools/src/main/java/org/apache/kafka/trogdor/common/Platform.java
##########
@@ -54,6 +62,29 @@ public static Platform parse(String curNodeName, String 
path) throws Exception {
         }
     }
 
+    class MetricsContainer {
+        private static TrogdorMetrics trogdorMetrics = null;

Review comment:
       I'm a bit confused by why this is static.  It seems like it should just 
be tracked by each Coordinator or Agent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to