[GitHub] [kafka] cmccabe commented on a change in pull request #8863: KAFKA-8528: Expose Trogdor-specific JMX metrics for Tasks and Agents

[GitBox]

cmccabe commented on a change in pull request #8863:
URL: https://github.com/apache/kafka/pull/8863#discussion_r450504170



##########
File path: 
tools/src/main/java/org/apache/kafka/trogdor/coordinator/TaskManager.java
##########
@@ -127,7 +127,12 @@
      */
     private long nextWorkerId;
 
-    TaskManager(Platform platform, Scheduler scheduler, long firstWorkerId) {
+    /**
+     * The TrogdorMetrics for this coordinator.
+     */
+    private TrogdorMetrics trogdorMetrics;

Review comment:
       This should be final and probably just be called "metrics" since there 
are no other metrics that we need to distinguish it from




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org