cmccabe commented on a change in pull request #8863:
URL: https://github.com/apache/kafka/pull/8863#discussion_r450921851



##########
File path: tools/src/main/java/org/apache/kafka/trogdor/agent/Agent.java
##########
@@ -92,6 +93,8 @@
 
     private final Time time;
 
+    final TrogdorMetrics trogdorMetrics;

Review comment:
       There are a few ways you could do this.  One is to have separate classes 
for agent metrics and coordinator metrics.  Another is to have a boolean or 
something that you pass in to determine whether agent or coordinator metrics 
are created.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to