ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r501336666



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##########
@@ -212,6 +213,7 @@ public void configure(final Map<String, ?> configs) {
         rebalanceProtocol = assignorConfiguration.rebalanceProtocol();
         taskAssignorSupplier = assignorConfiguration::taskAssignor;
         assignmentListener = assignorConfiguration.assignmentListener();
+        uniqueField = usedSubscriptionMetadataVersion >= 8 ? new byte[1] : new 
byte[0];

Review comment:
       That seems like an indication that the subscription is being encoded 
incorrectly. If the version is below 8, it shouldn't be trying to encode the 
`uniqueField` in the first place -- you shouldn't have to mimic that yourself 
by forcing it to be empty (and even if it is I worry there might be some 
additional bytes for metadata that would get stored for that field, when that 
field should not exist at all for versions < 8)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to